Don't do direct casts to int to prevent dart2wasm breakages.#2007
Don't do direct casts to int to prevent dart2wasm breakages.#2007jakemac53 merged 10 commits intodart-lang:masterfrom
Conversation
|
Are there tests in this repo that will fail without this change so that we don't regress? |
It looks like if we made a dart2wasm test that uses a timeout we could get that |
|
I'll write a test |
|
See https://github.com/dart-lang/test/tree/master/integration_tests/wasm which is probably the easiest place to put this test for now |
Fix dependencies in test to use the latest test_core in addition to the latest test_api
Co-authored-by: Jacob MacDonald <jakemac@google.com>
|
@eyebrowsoffire did you need a publish of this soon? @natebosch thoughts on when we should publish? |
|
I think I'm close to getting #2004 landable in google3 - I plan to publish after I can land that |
|
We have a workaround in Flutter for now, so there's no huge rush on a publish, but let me know there is a new version and we'll bump to it. |
3 participants
This fixes #2006